Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Python: separate pre-installed Python packages from library plugin #1310

Closed
dbrnz opened this issue May 11, 2017 · 5 comments
Closed

Python: separate pre-installed Python packages from library plugin #1310

dbrnz opened this issue May 11, 2017 · 5 comments
Assignees

Comments

@dbrnz
Copy link
Contributor

dbrnz commented May 11, 2017

At the moment, besides the Python library and associated run-time scripts, the Python plugin also contains Python packages that are not part of a standard Python release (e.g. numpy, scipy, Jupyter, etc...).

In order to simplify ongoing development, I propose the standard Python release to be in its own plugin, PythonLibrary, and to have another plugin, PythonPackages, for the set of Python packages we bundle with OpenCOR. This would also allow for future plugins to bundle Python packages without having to modify the base plugins.

@agarny
Copy link
Contributor

agarny commented May 12, 2017

Sounds good to me. Otherwise, why not even go further, i.e. have each Python package in their own plugin and thus mimic what we are already doing with third-party libraries?

@dbrnz
Copy link
Contributor Author

dbrnz commented May 15, 2017

Any Python package is likely to have several dependencies (e.g. installing numpy, scipy and matplotlib also installs the six, python-dateutil, pytz, pyparsing and cycler Python packages; installing jupyter also installs 36 other Python packages...); IMHO having a separate OpenCOR plugin for each Python package is realistic. Instead I propose having say a JupyterPackages plugin that puts the jupyter Python package and its 36 dependencies into the one pre-built OpenCOR package.

dbrnz added a commit to dbrnz/opencor that referenced this issue May 16, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue May 16, 2017
…ire SHA1 checking, so remove requirement to have at least one file (opencor#1310).
dbrnz added a commit to dbrnz/opencor that referenced this issue May 16, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue May 16, 2017
@agarny
Copy link
Contributor

agarny commented May 16, 2017

IMHO having a separate OpenCOR plugin for each Python package is realistic.

I imagine you meant UNrealistic?

Instead I propose having say a JupyterPackages plugin that puts the jupyter Python package and its 36 dependencies into the one pre-built OpenCOR package.

I am confused. JupyterPackages or PythonPackages in the end?

Whatever the case, I can now appreciate that having each Python package in their own plugin might be difficult, if not impossible.

So, going back to your original message, I would personally go for both a Python plugin (for Python itself) and a PythonPackages plugin (for all Python packages that we want to use with OpenCOR).

@dbrnz
Copy link
Contributor Author

dbrnz commented May 16, 2017

IMHO having a separate OpenCOR plugin for each Python package is realistic.

I imagine you meant UNrealistic?

:)

So, going back to your original message, I would personally go for both a Python plugin (for Python itself) and a PythonPackages plugin (for all Python packages that we want to use with OpenCOR).

I've been thinking of having more than one Python packages plugin, say one for the scientific packages (numpy, scipy, matplotlib) and another for Jupyter and its friends. Having said this I can also see the sense in keeping things simple and having all Python packages in the one plugin, so will do so. I will also rename the Python plugins as per your suggestion.

@dbrnz dbrnz self-assigned this May 16, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue May 19, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue May 19, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue May 19, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue May 19, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue May 19, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue May 19, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue May 19, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue May 19, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue May 19, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue May 26, 2017
dbrnz added a commit to dbrnz/opencor that referenced this issue Jun 1, 2017
@agarny agarny mentioned this issue Jun 29, 2017
13 tasks
@dbrnz
Copy link
Contributor Author

dbrnz commented Jun 29, 2017

Completed and ready for merge from pythonplugin branch. See issue #1255 for current status.

@dbrnz dbrnz closed this as completed Jun 29, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants