Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Jupyter kernel: make sure that implementation and implementation_version are properly set #2250

Closed
agarny opened this issue Dec 3, 2019 · 0 comments
Closed

Jupyter kernel: make sure that implementation and implementation_version are properly set #2250

agarny opened this issue Dec 3, 2019 · 0 comments
Assignees
@agarny
Labels
Python Task
Milestone
0.7

Comments

@agarny
Copy link
Contributor

agarny commented Dec 3, 2019

Right now, implementation is set to OpenCOR and implementation_version to 0.6. While the former would be fine, the latter is not accurate. So, we should have them set to qApp->applicationName() and qApp->applicationVersion(), respectively.
@agarny agarny added this to the 0.7 milestone Dec 3, 2019
@agarny agarny self-assigned this Dec 3, 2019
agarny added a commit to agarny/opencor that referenced this issue Dec 3, 2019
@agarny
Jupyter kernel: make sure that implementation and `implementation_v…
527e883 
…ersion` are properly set (opencor#2250).
agarny added a commit to agarny/opencor that referenced this issue Dec 3, 2019
@agarny
Slight update to our downloads page (opencor#2250).
6f3e549
@agarny agarny closed this as completed in 7dc27ae Dec 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@agarny agarny

Labels
Python Task
Projects
None yet
Milestone
0.7
Development

No branches or pull requests
1 participant
@agarny