Add Parquet-Exporter helm chart #195
Conversation
charts/parquet-exporter/Chart.yaml
Outdated
| @@ -0,0 +1,24 @@ | |||
| apiVersion: v2 | |||
| name: parquet-exporter | |||
There was a problem hiding this comment.
could we make this "opencost-parquet-exporter"?
There was a problem hiding this comment.
That will have a ripple effect in the templates, but I prefer the verbosity/specificity
charts/parquet-exporter/Chart.yaml
Outdated
| @@ -0,0 +1,24 @@ | |||
| apiVersion: v2 | |||
| name: parquet-exporter | |||
| description: A Helm chart for Kubernetes | |||
There was a problem hiding this comment.
"OpenCost Parquet Exporter"
charts/parquet-exporter/README.md
Outdated
| @@ -0,0 +1,38 @@ | |||
| # parquet-exporter | |||
There was a problem hiding this comment.
Could we make the title and the path charts/opencost-parquet-exporter to match the repository?
charts/parquet-exporter/README.md
Outdated
|
|
||
| | Key | Type | Default | Description | | ||
| |-----|------|---------|-------------| | ||
| | activeDeadlineSeconds | int | `3600` | Keep job runnig (from start time) for [activeDeadlineSeconds] | |
charts/parquet-exporter/values.yaml
Outdated
| - name: OPENCOST_PARQUET_S3_REGION | ||
| value: YOUR_S3_BUCKET_REGION_NAME_CHANGE_ME | ||
| - name: OPENCOST_PARQUET_SVC_HOSTNAME | ||
| value: opencost.opencost.svc.cluster.local. |
There was a problem hiding this comment.
is there supposed to be a trailing "."?
charts/parquet-exporter/Chart.yaml
Outdated
| @@ -0,0 +1,24 @@ | |||
| apiVersion: v2 | |||
| name: parquet-exporter | |||
There was a problem hiding this comment.
That will have a ripple effect in the templates, but I prefer the verbosity/specificity
charts/parquet-exporter/values.yaml
Outdated
| ttlSecondsAfterFinished: 14400 | ||
| # -- ServiceAccount use to run this pod | ||
| serviceAccount: | ||
| name: opencost |
There was a problem hiding this comment.
Does the exporter depend on the opencost service account? I couldn't find something related to this in the exporters repo README.md.
There was a problem hiding this comment.
I took that over from @lmello 's code. I have not looked into the actual requirements for the AWS S3 integration but I have to assume that its there for this purpose. Also it is not required to interact with the opencost application.
The service account key/value pair is optional however. Would you rather have me remove it from the values yaml or adjust the description to state that its an optional parameter`
There was a problem hiding this comment.
If the service account is not required, I would leave it empty. Maybe also change the key to existingServiceAccount? Otherwise I would assume that it creates the service account by itself.
There was a problem hiding this comment.
Thank you. Ill change accordingly!
charts/parquet-exporter/values.yaml
Outdated
… tag to :main, implement review comments
…sed when not empty
| {{/* | ||
| Common labels | ||
| */}} | ||
| {{- define "parquet-exporter.annotations" -}} |
There was a problem hiding this comment.
do the "parquet-exporter" references need to be changed to "opencost-parquest-exporter" across the board?
There was a problem hiding this comment.
It would be consistent with actual chart name. I'll update accordingly
|
This pull request has been marked as stale because it has been open for 60 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days. |
Moved from opencost/opencost-parquet-exporter#10
Hey everyone,
I've created a first draft of a helm chart for the parquet-exporter. I do not have a setup where I can use AWS as of now, therefore the actual push to a S3 bucket is not yet tested. However, I was able to install the chart and run the cronjob in my minikube.
Used helm-docs to create a rough documentation around the chart
The chart itself is relatively straight forward I think
Let me know what you think!