Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Interfaces needed in Kubecost Asset and CloudCost item for mapping monitored to billed resources #1695

Merged

Conversation

avrodrigues5
Copy link
Contributor

What does this PR change?

  • Few functions needed to match billed to monitored resources such as
    monitoring key with provider/account/providerID in both asset and cloud cost items and accumulate in cloudcostItemset

Does this PR relate to any other PRs?

  • KCM PR link soon

How will this PR impact users?

  • No Impact

Does this PR address any GitHub or Zendesk issues?

  • Closes ... Or JIRA Issue to get unmonitored Clusters

How was this PR tested?

  • On all 4 providers in conjunction with KCM PR

Does this PR require changes to documentation?

  • Not now

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next Opencost release? If not, why not?

  • Dont have permission can some opencosters do it for me!

pkg/kubecost/asset.go Outdated Show resolved Hide resolved
@avrodrigues5 avrodrigues5 force-pushed the avr/functions-for-clusterstatus branch 2 times, most recently from 3341764 to 189b24a Compare February 17, 2023 00:52
…or matching billed vs monitored resources

Signed-off-by: Alan Rodrigues <alanr5691@yahoo.com>
… values

Signed-off-by: Alan Rodrigues <alanr5691@yahoo.com>
…roviders

Signed-off-by: Alan Rodrigues <alanr5691@yahoo.com>
@nikovacevic nikovacevic merged commit 265b8be into opencost:develop Feb 21, 2023
@avrodrigues5 avrodrigues5 deleted the avr/functions-for-clusterstatus branch February 21, 2023 23:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants