Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change default allocation/compute aggregation to match allocation end… #2050

Merged

Conversation

saweber
Copy link
Contributor

@saweber saweber commented Jul 20, 2023

…point

What does this PR change?

  • /allocation/compute now defaults aggregation to cluster,node,namespace,pod,container

Does this PR relate to any other PRs?

  • no

How will this PR impact users?

  • yes; default aggregation has changed

Does this PR address any GitHub or Zendesk issues?

How was this PR tested?

  • manually + unit test

Does this PR require changes to documentation?

  • yes, included

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

  • can't

@saweber saweber force-pushed the BURNDOWN-129/alloc-compute-default-agg branch from ef0a264 to be62540 Compare July 20, 2023 21:16
@saweber saweber force-pushed the BURNDOWN-129/alloc-compute-default-agg branch 2 times, most recently from c82fe14 to 161485e Compare July 21, 2023 14:41
…point

Signed-off-by: saweber <saweber@gmail.com>
@saweber saweber force-pushed the BURNDOWN-129/alloc-compute-default-agg branch from 714df2d to d4b47c5 Compare July 25, 2023 00:43
@nikovacevic nikovacevic merged commit 10d9601 into opencost:develop Jul 25, 2023
3 checks passed
@saweber saweber deleted the BURNDOWN-129/alloc-compute-default-agg branch September 18, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants