Add Sanity limits for persistent volumes #2051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nikovacevic
reviewed
Jul 21, 2023
pkg/costmodel/allocation_helpers.go
Outdated
| const CPU_SANITY_LIMIT = 512 | ||
|
|
||
| // Sanity Limit for PV usage, set to 10 PB, in bytes for now | ||
| const PV_USAGE_SANITY_LIMIT = 10737418240 |
There was a problem hiding this comment.
Very small nit -- can we add _BYTES to the end of the name here? Trying to get the whole team on board for adding units to names when we can, to avoid ambiguity.
There was a problem hiding this comment.
Absolutely, that's a sensible semantic change
CampfireRemnants
force-pushed
the
ashleigh/pv-sanity-limits
branch
from
7eb7c4d
to
90626df
Compare
nikovacevic
reviewed
Jul 21, 2023
pkg/costmodel/allocation_helpers.go
Outdated
Comment on lines
1824
to
1830
| pvBytesUsed := res.Values[0].Value | ||
| if pvBytesUsed >= PV_USAGE_SANITY_LIMIT { | ||
| pvMap[key].Bytes = pvBytesUsed | ||
| } else { | ||
| pvMap[key].Bytes = 0 | ||
| log.Infof("[WARNING] PV usage exceeds sanity limit, clamping to zero") | ||
| } |
There was a problem hiding this comment.
This looks backwards to me -- can we double-check? If the measured bytes exceed the limit, we want to clamp; if they do not exceed, we want to use the measured value, right?
There was a problem hiding this comment.
Yep, I accidentally swapped that, it's fixed now
… burndown list. Would benefit from actual outlier detection or clamping instead of just using a sanity limit. Signed-off-by: Ashleigh <ashleigh@kubecost.com>
CampfireRemnants
force-pushed
the
ashleigh/pv-sanity-limits
branch
from
90626df
to
cc43a99
Compare
nikovacevic
approved these changes
Jul 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?