Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sean/remove etl audit types #2058

Merged
merged 2 commits into from Jul 27, 2023
Merged

Conversation

Sean-Holcomb
Copy link
Contributor

What does this PR change?

  • This PR removes the ETL audit types from the kubecost package along with some other unused types. This PR contains a bingen run which removes these types, while the diff may look concerning on the codecs this is the diff run before the removing the type:
Screenshot 2023-07-27 at 10 47 01 AM

Does this PR relate to any other PRs?

How will this PR impact users?

  • User should not see impact

Does this PR address any GitHub or Zendesk issues?

  • Closes ...

How was this PR tested?

  • PR removes dead code, tested to ensure builds

Does this PR require changes to documentation?

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

  • This does not need to go into 1.106

Signed-off-by: Sean Holcomb <seanholcomb@gmail.com>
Signed-off-by: Sean Holcomb <seanholcomb@gmail.com>
@Sean-Holcomb Sean-Holcomb merged commit c88a5ba into develop Jul 27, 2023
3 checks passed
@mattray mattray deleted the sean/remove-etl-audit-types branch January 18, 2024 21:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants