WIP: stop NaNs from propogating through opencost and kubecost #2069
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saweber
force-pushed
the
GTM-12/stop-NaNs
branch
4 times, most recently
from
d0fad1d
to
af5308c
Compare
saweber
commented
Aug 8, 2023
| SharedCostBreakdown: SharedCostBreakdowns{"NaN": getMockSharedCostBreakdown(f)}, | ||
| LoadBalancers: LbAllocations{"NaN": getMockLbAllocation(f)}, | ||
| } | ||
| return alloc |
There was a problem hiding this comment.
I would like to convert these mock functions to use reflection (like the check function) if I have any extra time.
saweber
commented
Aug 8, 2023
| } | ||
|
|
||
| func checkAllocation(t *testing.T, tcName string, alloc Allocation) { | ||
| v := reflect.ValueOf(alloc) |
There was a problem hiding this comment.
There is a lot of use of reflect in here to avoid repetitive code - but only for tests.
saweber
commented
Aug 8, 2023
saweber
force-pushed
the
GTM-12/stop-NaNs
branch
3 times, most recently
from
c4391f9
to
6b9edb3
Compare
Signed-off-by: saweber <saweber@gmail.com>
saweber
force-pushed
the
GTM-12/stop-NaNs
branch
from
6b9edb3
to
41f3de4
Compare
nikovacevic
approved these changes
Aug 8, 2023
nikovacevic
added a commit
that referenced
this pull request
Aug 10, 2023
Cherry pick of #2069: stop NaNs from propogating through opencost and kubecost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?