GCP Provider Cluster Filter Fix #2116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Unsure as to why this went untested, but this should correctly fix the query formatting. Signed-off-by: Matt Bolt <mbolt35@gmail.com>
nikovacevic
approved these changes
Aug 22, 2023
|
Introduced in #1430 |
ameijer
added a commit
to ameijer/opencost
that referenced
this pull request
Aug 28, 2023
…-id-csi-vols * commit '3b6dca83aad59ec72f8cc702ae7b7cc743649828': When unable to properly remove a metric from the CostModelMetricsEmitter, log an Error. (opencost#2109) add quarterly accum opt (opencost#2120) BURNDOWN-209 fix Inf and negative values in pod-to-PVC attribution Added special case for unallocated/unassigned aliased fields when filtering. Added additional test case for filtering into an unallocated aliased field. (opencost#2114) GCP Provider Cluster Filter Fix (opencost#2116) improve auth error handling and response for AWS orphaned resources GTM-63 sanitize label names before metric emission to prevent label name collisions pkg/cloud/alibaba: fix dropped errors refactor: renamed path arguments to filePath in order to prevent import alias for path feat: changed custom s3 endpoint naming and scheme to alts3, used aws sdk based s3 client endpoint construction fix non deletion of nodes from node metrics due to dependency added on node arch types add ip field to load balancers GTM-52 Fix parsing of GCP pricing and create new node diagnostic pricing API disabled healthz endpoint logging fix subquery fallback to not have dependency on metric relabel if users doesnt provide it in BYO prometheus (opencost#2076) feat: add custom s3 export endpoint
ameijer
pushed a commit
to ameijer/opencost
that referenced
this pull request
Aug 28, 2023
Unsure as to why this went untested, but this should correctly fix the query formatting. Signed-off-by: Matt Bolt <mbolt35@gmail.com> Signed-off-by: Alex Meijer <ameijer@kubecost.com>
ameijer
added a commit
to ameijer/opencost
that referenced
this pull request
Aug 28, 2023
…-id-csi-vols * commit '3b6dca83aad59ec72f8cc702ae7b7cc743649828': When unable to properly remove a metric from the CostModelMetricsEmitter, log an Error. (opencost#2109) add quarterly accum opt (opencost#2120) BURNDOWN-209 fix Inf and negative values in pod-to-PVC attribution Added special case for unallocated/unassigned aliased fields when filtering. Added additional test case for filtering into an unallocated aliased field. (opencost#2114) GCP Provider Cluster Filter Fix (opencost#2116) improve auth error handling and response for AWS orphaned resources GTM-63 sanitize label names before metric emission to prevent label name collisions pkg/cloud/alibaba: fix dropped errors refactor: renamed path arguments to filePath in order to prevent import alias for path feat: changed custom s3 endpoint naming and scheme to alts3, used aws sdk based s3 client endpoint construction fix non deletion of nodes from node metrics due to dependency added on node arch types add ip field to load balancers GTM-52 Fix parsing of GCP pricing and create new node diagnostic pricing API disabled healthz endpoint logging fix subquery fallback to not have dependency on metric relabel if users doesnt provide it in BYO prometheus (opencost#2076) feat: add custom s3 export endpoint # Conflicts: # pkg/kubecost/bingen.go # pkg/kubecost/kubecost_codecs.go
ameijer
pushed a commit
to ameijer/opencost
that referenced
this pull request
Aug 28, 2023
Unsure as to why this went untested, but this should correctly fix the query formatting. Signed-off-by: Matt Bolt <mbolt35@gmail.com> Signed-off-by: Alex Meijer <ameijer@kubecost.com>
ameijer
pushed a commit
to ameijer/opencost
that referenced
this pull request
Aug 28, 2023
Unsure as to why this went untested, but this should correctly fix the query formatting. Signed-off-by: Matt Bolt <mbolt35@gmail.com> Signed-off-by: Alex Meijer <ameijer@kubecost.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unsure as to why this went untested, but this should correctly fix the query formatting.