-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
prevent error on catalog missing from config #2170
Conversation
Signed-off-by: Sean Holcomb <seanholcomb@gmail.com>
pkg/cloud/aws/athenaconfiguration.go
Outdated
return fmt.Errorf("AthenaConfiguration: UnmarshalJSON: %s", err.Error()) | ||
if _, ok := fmap["catalog"]; ok { | ||
catalog, err := config.GetInterfaceValue[string](fmap, "catalog") | ||
if err == nil { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should be !=
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^^
Signed-off-by: Sean Holcomb <seanholcomb@gmail.com>
if _, ok := fmap["catalog"]; ok { | ||
catalog, err := config.GetInterfaceValue[string](fmap, "catalog") | ||
if err != nil { | ||
return fmt.Errorf("AthenaConfiguration: UnmarshalJSON: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@michaelmdresser you are slipping man, you didn't even comment on the unwrapped errors
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆 ahh its a dark day isn't it
if _, ok := fmap["catalog"]; ok { | ||
catalog, err := config.GetInterfaceValue[string](fmap, "catalog") | ||
if err != nil { | ||
return fmt.Errorf("AthenaConfiguration: UnmarshalJSON: %w", err) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
😆 ahh its a dark day isn't it
thank you for the fix @michaelmdresser 🏆 |
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
no impact to user
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?