Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "mimir" to info log message #2180

Merged
merged 1 commit into from Sep 25, 2023
Merged

Add "mimir" to info log message #2180

merged 1 commit into from Sep 25, 2023

Conversation

skl
Copy link
Contributor

@skl skl commented Sep 25, 2023

What does this PR change?

  • Add "mimir" to info log message

Does this PR relate to any other PRs?

  • No

How will this PR impact users?

  • Improves log messaging for mimir users

How was this PR tested?

  • There don't appear to be any tests for these files.

Does this PR require changes to documentation?

  • No

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

@skl
Add "mimir" to info log message
d4685f9 
Signed-off-by: Stephen Lang <stephen.lang@grafana.com>
@skl skl requested review from mbolt35 and mattray September 25, 2023 11:30
@skl skl marked this pull request as ready for review September 25, 2023 11:30
Pokom
Pokom approved these changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@Pokom Pokom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simple enough change and helps clarify when this error message is stated.

Possible improvement for a later time would be to check which type of client is being instantiated and skip the configuration all together, but that would require a bit of refactor.

@cliffcolvin cliffcolvin added P2 Estimated Priority (P0 is highest, P4 is lowest) E1 Estimated level of Effort (1 is easiest, 4 is hardest) labels Sep 25, 2023
cliffcolvin
cliffcolvin approved these changes Sep 25, 2023
View reviewed changes
Copy link
Member

@cliffcolvin cliffcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Easy enough change. Thanks for adding this @Pokom.

@cliffcolvin cliffcolvin merged commit a72fbf6 into opencost:develop Sep 25, 2023
3 checks passed
@skl skl mentioned this pull request Nov 23, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Pokom Pokom Pokom approved these changes

@cliffcolvin cliffcolvin cliffcolvin approved these changes

@mbolt35 mbolt35 Awaiting requested review from mbolt35

@mattray mattray Awaiting requested review from mattray

Assignees
No one assigned
Labels
E1 Estimated level of Effort (1 is easiest, 4 is hardest) P2 Estimated Priority (P0 is highest, P4 is lowest)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@skl @Pokom @cliffcolvin