Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

orphaned resources repair #2224

Merged
merged 4 commits into from Oct 19, 2023

Conversation

ameijer
Copy link
Contributor

@ameijer ameijer commented Oct 19, 2023

What does this PR change?

  • fixes orphaned resources logic, supporting multiple regions and fixing null descriptions for disks

Does this PR relate to any other PRs?

  • none

How will this PR impact users?

  • will allow orphaed resources to work in aws outside of US east 2

Does this PR address any GitHub or Zendesk issues?

  • Closes ...

How was this PR tested?

  • tested with jesse's test cluster

Does this PR require changes to documentation?

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

@ameijer ameijer changed the title provide tags for volumes orphaned resources repair Oct 19, 2023
nikovacevic and others added 3 commits October 19, 2023 09:06
Signed-off-by: Niko Kovacevic <nikovacevic@gmail.com>
Signed-off-by: Alex Meijer <ameijer@kubecost.com>
Signed-off-by: Alex Meijer <ameijer@kubecost.com>
Signed-off-by: Alex Meijer <ameijer@kubecost.com>
Copy link
Member

@cliffcolvin cliffcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great catch!

@nikovacevic nikovacevic merged commit 482dc54 into opencost:develop Oct 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants