Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix panic when running KCM/OC locally when downloading pricing data #2245

Merged
merged 1 commit into from Oct 26, 2023

Conversation

saweber
Copy link
Contributor

@saweber saweber commented Oct 26, 2023

What does this PR change?

  • fixes panic occuring when running Kubecost or OpenCost locally

Does this PR relate to any other PRs?

How will this PR impact users?

  • application won't crash

Does this PR address any GitHub or Zendesk issues?

  • none

How was this PR tested?

  • make sure Kubecost doesn't crash on startup

Does this PR require changes to documentation?

  • no

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

  • can't

Copy link
Member

@cliffcolvin cliffcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nikovacevic nikovacevic merged commit 28ac03a into opencost:develop Oct 26, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants