Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nil out overhead when adding nil to non-nil #2251

Merged
merged 1 commit into from Oct 27, 2023
Merged

Nil out overhead when adding nil to non-nil #2251

merged 1 commit into from Oct 27, 2023

Conversation

michaelmdresser
Copy link
Contributor

What does this PR change?

  • When adding a Node with nil overhead to one with non-nil overhead, the resulting overhead is now nil. This avoids hiding unknowns.

How was this PR tested?

  • New unit test

@michaelmdresser
Nil out overhead when adding nil to non-nil
6853c6d 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
cliffcolvin
cliffcolvin approved these changes Oct 27, 2023
View reviewed changes
Copy link
Member

@cliffcolvin cliffcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michaelmdresser michaelmdresser merged commit 0d113a0 into develop Oct 27, 2023
3 checks passed
@michaelmdresser michaelmdresser deleted the mmd/nil-out-added-nil-overhead branch October 27, 2023 20:27
michaelmdresser added a commit that referenced this pull request Oct 27, 2023
@michaelmdresser
Nil out overhead when adding nil to non-nil (#2251)
1eac4ac 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser michaelmdresser mentioned this pull request Oct 27, 2023
Merged
michaelmdresser added a commit that referenced this pull request Oct 27, 2023
@michaelmdresser
Nil out overhead when adding nil to non-nil (#2251) (#2252)
e31b54a 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
teevans pushed a commit to jjarrett21/opencost that referenced this pull request Oct 31, 2023
@michaelmdresser @teevans
Nil out overhead when adding nil to non-nil (opencost#2251)
2326892 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
Signed-off-by: Thomas Evans <tevans3@icloud.com>
AndrewChubatiuk pushed a commit to AndrewChubatiuk/opencost that referenced this pull request Nov 16, 2023
@michaelmdresser
Nil out overhead when adding nil to non-nil (opencost#2251)
3b0d349 
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cliffcolvin cliffcolvin cliffcolvin approved these changes

Assignees
No one assigned
Labels
v1.107
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@michaelmdresser @cliffcolvin