Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

check for nil struct before sanitizing #2256

Merged
merged 1 commit into from Oct 30, 2023
Merged

check for nil struct before sanitizing #2256

merged 1 commit into from Oct 30, 2023

Conversation

ameijer
Copy link
Contributor

@ameijer ameijer commented Oct 30, 2023

cherry pick of #2255

@ameijer
check for nil struct before sanitizing
95c27c9 
Signed-off-by: Alex Meijer <ameijer@kubecost.com>
(cherry picked from commit b5828bd)
CampfireRemnants
CampfireRemnants approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@CampfireRemnants CampfireRemnants left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure looks like it's doing exactly what you said it's doing

@michaelmdresser michaelmdresser merged commit 0b91400 into opencost:v1.107 Oct 30, 2023
1 check passed
@ameijer ameijer deleted the v-1.107-Patch/sanitize-nil-guard branch October 30, 2023 17:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelmdresser michaelmdresser michaelmdresser approved these changes

@CampfireRemnants CampfireRemnants CampfireRemnants approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@ameijer @michaelmdresser @CampfireRemnants