-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cloud Cost UI goes blank with no cloud-integration.json as a secret #2287
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Updated the styles to be a bit more consistent with what we have previously |
@dwbrown2 changed it so that it should only show one or the other. |
@jjarrett21 I'm just seeing the error message now, should we instead expect to see the "no cloud integration" message? |
how bout now? |
I'm not seeing anything in preview: https://opencost-qbpimiolx-kubecost.vercel.app/ Have a screenshot? |
Haven't reviewed code, but this looks good to me! This isn't the right docs page though, we want to use an OpenCost page: https://docs.kubecost.com/using-kubecost/navigating-the-kubecost-ui/cloud-costs-explorer#installation-and-configuration Nit: I might also open the docs link in a new window. |
done and done |
I'm still seeing kubecost docs referenced in code, but once that's done I think the UX is good! Would be great to get a maintainer review when ready. |
I know @mattray is likely out for the weekend, so sharing this in case helpful: https://www.opencost.io/docs/configuration/#cloud-costs We may want to change/improve but this at least feels like a fine starting point. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Tested locally
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?