Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cloud Cost UI goes blank with no cloud-integration.json as a secret #2287

Merged
merged 11 commits into from Nov 28, 2023

Conversation

jjarrett21
Copy link
Contributor

@jjarrett21 jjarrett21 commented Nov 3, 2023

What does this PR change?

  • Checks for cloud cost status

Does this PR relate to any other PRs?

  • no

How will this PR impact users?

  • should show an error message and a docs link if they don't have cloud cost enabled

Does this PR address any GitHub or Zendesk issues?

How was this PR tested?

  • self

Does this PR require changes to documentation?

  • no but the included docs link is wrong and @mattray will need to provide the correct one.

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

Screenshot 2023-11-03 at 11 46 34 PM

Copy link

vercel bot commented Nov 3, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 28, 2023 11:34am

@jjarrett21
Copy link
Contributor Author

Updated the styles to be a bit more consistent with what we have previously

@dwbrown2
Copy link
Collaborator

dwbrown2 commented Nov 6, 2023

Would it be easy to remove the upper error box? If so, like that change?

image

@jjarrett21
Copy link
Contributor Author

@dwbrown2 changed it so that it should only show one or the other.

@dwbrown2
Copy link
Collaborator

dwbrown2 commented Nov 8, 2023

@jjarrett21 I'm just seeing the error message now, should we instead expect to see the "no cloud integration" message?

image

@jjarrett21
Copy link
Contributor Author

how bout now?

@dwbrown2
Copy link
Collaborator

dwbrown2 commented Nov 9, 2023

I'm not seeing anything in preview: https://opencost-qbpimiolx-kubecost.vercel.app/

Have a screenshot?

@jjarrett21
Copy link
Contributor Author

Screenshot 2023-11-09 at 3 57 38 PM @dwbrown2 😅

@dwbrown2
Copy link
Collaborator

dwbrown2 commented Nov 9, 2023

Haven't reviewed code, but this looks good to me!

This isn't the right docs page though, we want to use an OpenCost page: https://docs.kubecost.com/using-kubecost/navigating-the-kubecost-ui/cloud-costs-explorer#installation-and-configuration

Nit: I might also open the docs link in a new window.

@jjarrett21
Copy link
Contributor Author

done and done

@dwbrown2
Copy link
Collaborator

I'm still seeing kubecost docs referenced in code, but once that's done I think the UX is good! Would be great to get a maintainer review when ready.

@jjarrett21
Copy link
Contributor Author

Oh @dwbrown2 I was moving fast and I thought the link you posted was the open cost one lol. I'll ask @mattray for the proper docs link

@dwbrown2
Copy link
Collaborator

I know @mattray is likely out for the weekend, so sharing this in case helpful: https://www.opencost.io/docs/configuration/#cloud-costs

We may want to change/improve but this at least feels like a fine starting point.

Copy link
Collaborator

@mattray mattray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested locally

@mattray mattray merged commit 0faee09 into opencost:develop Nov 28, 2023
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Cloud Cost UI goes blank with no cloud-integration.json as a secret
3 participants