Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add fix for GCP instance types that contain 'Nvidia' but not 'Nvidia Tesla' in description #2295

Merged
merged 1 commit into from Nov 29, 2023

Conversation

saweber
Copy link
Contributor

@saweber saweber commented Nov 7, 2023

What does this PR change?

  • Update GCP Billing Parsing Logic to get pricing data for non-'Tesla' Nvidia GPUs

Does this PR relate to any other PRs?

How will this PR impact users?

  • More GCP GPU types will have billing data available (g2 instance type)

Does this PR address any GitHub or Zendesk issues?

How was this PR tested?

  • Debug code; all GCP instance billing items with a Description containing 'Nvidia' have GPU pricing logic applied

Does this PR require changes to documentation?

  • No

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

  • Can't

Copy link

vercel bot commented Nov 7, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 29, 2023 4:36pm

@saweber saweber changed the title add fix for GCP instance types that are Nvidia but not Nvidia Tesla add fix for GCP instance types that contain 'Nvidia' but not 'Nvidia Tesla' in description Nov 7, 2023
@nikovacevic nikovacevic merged commit 7bc5a26 into opencost:develop Nov 29, 2023
5 of 6 checks passed
@saweber saweber deleted the saweber/gcp-g2-instance-fix branch November 29, 2023 18:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants