Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing items in Azure CloudCosts #2324

Merged
merged 2 commits into from Nov 22, 2023

Conversation

kaelanspatel
Copy link
Contributor

What does this PR change?

Fixes an issue where Azure cloud costs from CSV were not parsing Other cloudcosts, causing missing line items.

Does this PR relate to any other PRs?

No.

How will this PR impact users?

Fixes an issue with missing items in cloudcosts.

Does this PR address any GitHub or Zendesk issues?

  • Closes ...

How was this PR tested?

  • Tested parsing customer CSV data before and after change in separate local go test.

Does this PR require changes to documentation?

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 10:32pm

Signed-off-by: Kaelan Patel <kaelanspatel@gmail.com>
Copy link
Contributor

@Sean-Holcomb Sean-Holcomb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great Catch

@Sean-Holcomb Sean-Holcomb merged commit 762fa73 into opencost:develop Nov 22, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants