Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re impl code coverage #2332

Merged
merged 7 commits into from Nov 22, 2023
Merged

Conversation

ameijer
Copy link
Contributor

@ameijer ameijer commented Nov 22, 2023

What does this PR change?

Does this PR relate to any other PRs?

How will this PR impact users?

Does this PR address any GitHub or Zendesk issues?

  • Closes ...

How was this PR tested?

Does this PR require changes to documentation?

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

ameijer and others added 6 commits November 22, 2023 15:08
Signed-off-by: Alex Meijer <ameijer@kubecost.com>
Signed-off-by: Alex Meijer <ameijer@kubecost.com>
Signed-off-by: Alex Meijer <ameijer@kubecost.com>
Signed-off-by: Alex Meijer <ameijer@kubecost.com>
Copy link

vercel bot commented Nov 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 22, 2023 9:16pm

Signed-off-by: Alex Meijer <ameijer@users.noreply.github.com>
Copy link

sonarcloud bot commented Nov 22, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
5.6% 5.6% Duplication

@michaelmdresser michaelmdresser merged commit 118fcdd into opencost:develop Nov 22, 2023
7 checks passed
cliffcolvin pushed a commit to cliffcolvin/opencost that referenced this pull request Dec 4, 2023
* trying new approach for secure results uploading

Signed-off-by: Alex Meijer <ameijer@kubecost.com>

* fix coverage syntax

Signed-off-by: Alex Meijer <ameijer@kubecost.com>

* fix naming, workflow trigger

Signed-off-by: Alex Meijer <ameijer@kubecost.com>

* double quote

Signed-off-by: Alex Meijer <ameijer@kubecost.com>

---------

Signed-off-by: Alex Meijer <ameijer@kubecost.com>
Signed-off-by: Alex Meijer <ameijer@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants