Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pkg/kubecost: fix clobbered errors #2337

Merged
merged 1 commit into from Nov 27, 2023

Conversation

alrs
Copy link
Contributor

@alrs alrs commented Nov 27, 2023

This picks up two err variables that were being lost because of the use of := inside a for loop.

Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
Copy link

vercel bot commented Nov 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 27, 2023 5:37pm

pkg/kubecost/asset.go Show resolved Hide resolved
pkg/kubecost/asset.go Show resolved Hide resolved
Copy link
Contributor

@michaelmdresser michaelmdresser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@michaelmdresser michaelmdresser merged commit 47a82e4 into opencost:develop Nov 27, 2023
5 of 6 checks passed
cliffcolvin pushed a commit to cliffcolvin/opencost that referenced this pull request Dec 4, 2023
Signed-off-by: Lars Lehtonen <lars.lehtonen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants