Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix test, add defensive check to scaleway #2354

Merged
merged 2 commits into from Dec 1, 2023

Conversation

AjayTripathy
Copy link
Contributor

What does this PR change?

  • Defensive check in case a scalway pv is missing a label
  • Fix test that was flaking due to order of retrieved keys varying.

Does this PR relate to any other PRs?

  • No

How will this PR impact users?

  • If you deploy on a scaleway PV without the right PV labels, no panics

How was this PR tested?

  • Fake scaleway node with no labels

Does this PR require changes to documentation?

  • No

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

  • v1.108

Copy link

vercel bot commented Nov 30, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 1, 2023 4:42pm

Copy link

sonarcloud bot commented Dec 1, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@AjayTripathy AjayTripathy merged commit 952357d into develop Dec 1, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants