-
Notifications
You must be signed in to change notification settings - Fork 518
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add labels to cloud cost view table rows #2371
Conversation
Signed-off-by: Sean Holcomb <seanholcomb@gmail.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
QueryViewTotals(ViewQueryRequest, context.Context) (*ViewTableRow, int, error) | ||
QueryViewTotals(ViewQueryRequest, context.Context) (*ViewTotals, error) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice
if cloudCost.Properties != nil { | ||
labels = cloudCost.Properties.Labels | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should cloudCost.Properties.Labels
be full copied here instead of just pointer copied?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is being pulled for binary for this purpose only so a full copy just seemed like an unnecessary memory bump
Kudos, SonarCloud Quality Gate passed! |
What does this PR change?
Adds labels to the cloudcost.ViewTableRow struct so that they can be displayed in pills on the CloudCost page.
Update the response from
QueryViewTotals
on the cloudcost.ViewQuerier interface to a match the type it is converted to for responseDoes this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?