aggregate by all if aggregate is empty #2376
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pkg/cloudcost/queryservice_helper.go
Outdated
| @@ -38,6 +38,11 @@ func ParseCloudCostRequest(qp httputil.QueryParams) (*QueryRequest, error) { | |||
| aggregateBy = append(aggregateBy, prop) | |||
| } | |||
|
|
|||
| // if we're aggregating by nothing (aka `item` on the frontend) then aggregate by all | |||
| if aggregateBy != nil && len(aggregateBy) < 1 { | |||
There was a problem hiding this comment.
GetList() returns nil if the string is empty https://github.com/opencost/opencost/blob/develop/pkg/util/mapper/mapper.go#L440
| if aggregateBy != nil && len(aggregateBy) < 1 { | |
| if len(aggregateBy) == 0 { |
should work
There was a problem hiding this comment.
This fails the tests
There was a problem hiding this comment.
aggregateBy != nil was what fixed it but probably caused the issue to not get solved
There was a problem hiding this comment.
I think we should change the test; behavior isn't working as its supposed to so we're fixing a bug. I'd say that the unit test is wrong.
There was a problem hiding this comment.
So, we probably need to do the "all" thing and treat both nil and {} as "do not aggregate." Which might mean that we need a test change? Does that sound right?
There was a problem hiding this comment.
ok let me nuke the test for now just to make sure this solves the problem
There was a problem hiding this comment.
I'm not sure I'm clear on what "do not aggregate" means. Would that just return one line item or something?
There was a problem hiding this comment.
By "do not aggregate" I believe niko means "return maximum-resolution lines", the same as a "full group by"
There was a problem hiding this comment.
So what's all then? I thought that would be full group by
There was a problem hiding this comment.
I believe "all" is supposed to produce a single, fully-totalled, line
Signed-off-by: nickcurie <ncurie@kubecost.com>
nickcurie
force-pushed
the
nick/cloud-cost-empty-aggregate
branch
from
53214dc
to
82d7065
Compare
Signed-off-by: nickcurie <ncurie@kubecost.com>
nickcurie
force-pushed
the
nick/cloud-cost-empty-aggregate
branch
from
7531495
to
6c19d08
Compare
* aggregate by all if aggregate is empty Signed-off-by: nickcurie <ncurie@kubecost.com> * resolved broken test Signed-off-by: nickcurie <ncurie@kubecost.com> --------- Signed-off-by: nickcurie <ncurie@kubecost.com>
* aggregate by all if aggregate is empty Signed-off-by: nickcurie <ncurie@kubecost.com> * resolved broken test Signed-off-by: nickcurie <ncurie@kubecost.com> --------- Signed-off-by: nickcurie <ncurie@kubecost.com> Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
* aggregate by all if aggregate is empty * resolved broken test --------- Signed-off-by: nickcurie <ncurie@kubecost.com> Signed-off-by: Michael Dresser <michaelmdresser@gmail.com> Co-authored-by: Nick Curie <32180999+nickcurie@users.noreply.github.com>
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?