Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: 2323 adding version and commit on opencost-ui logs #2388

Merged
merged 1 commit into from Dec 15, 2023

Conversation

brito-rafa
Copy link
Contributor

What does this PR change?

  • It adds version and commit on opencost-ui logs

Does this PR relate to any other PRs?

  • No

How will this PR impact users?

  • upon running kubectl logs <pod> -c opencost-ui, users will see the version and commit SHA of the container.

Does this PR address any GitHub or Zendesk issues?

  • Closes ... 2323

How was this PR tested?

  • See commnad below:
% docker run quay.io/brito_rafa0/opencost-ui:testa
Unable to find image 'quay.io/brito_rafa0/opencost-ui:testa' locally
testa: Pulling from brito_rafa0/opencost-ui
Digest: sha256:bd2d828ae209e4f314159821225783d61c3439e2f0b94339393ef0c19f86ae54
Status: Downloaded newer image for quay.io/brito_rafa0/opencost-ui:testa
running with BASE_URL=/model
Starting ui version 2323-ui-version-c2bc77c0-WIP (c2bc77c0) ## <-----------------------------
/docker-entrypoint.sh: /docker-entrypoint.d/ is not empty, will attempt to perform configuration
/docker-entrypoint.sh: Looking for shell scripts in /docker-entrypoint.d/
/docker-entrypoint.sh: Launching /docker-entrypoint.d/10-listen-on-ipv6-by-default.sh

Does this PR require changes to documentation?

  • No

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

  • Yes

Signed-off-by: Rafael Brito <rafa@stormforge.io>
Copy link

vercel bot commented Dec 15, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 15, 2023 5:12am

Copy link
Contributor

@michaelmdresser michaelmdresser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution!

@michaelmdresser michaelmdresser merged commit f75601f into opencost:develop Dec 15, 2023
6 checks passed
@mattray mattray added this to the v1.109 milestone Dec 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants