Make telemetry metrics respect disable state #2409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmdresser
added
the
next release
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
michaelmdresser
force-pushed
the
mmd/remove-obsolete-telemetry-metrics
branch
from
1776dc4
to
d812b88
Compare
|
|
@jessegoodier a KCM image which includes this change: |
|
this works! let me know if you want any test details. |
Sean-Holcomb
approved these changes
Dec 21, 2023
michaelmdresser
added a commit
that referenced
this pull request
Dec 21, 2023
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
Merged
michaelmdresser
added a commit
that referenced
this pull request
Dec 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
opencost_build_info,kubecost_http_requests_total,kubecost_http_response_time_seconds, andkubecost_http_response_size_byteswill now respect the disabled metric configuration.Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?