Fix a test that relies on Prom library #2432
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
michaelmdresser
requested review from
nikovacevic,
Sean-Holcomb and
cliffcolvin
saweber
approved these changes
Jan 3, 2024
pkg/kubecost/window_test.go
Outdated
| expDurSecStr := fmt.Sprintf("%ds", expDurSec) | ||
| expDurMin := int(now.Sub(startOfToday).Minutes()) | ||
| expDurMinStr := fmt.Sprintf("%dm", expDurMin) | ||
| if dur != expDurSecStr { |
There was a problem hiding this comment.
super nit: any particular reason to not AND the two conditions?
There was a problem hiding this comment.
No good reason at all -- fixed, thanks!
michaelmdresser
force-pushed
the
mmd/fix-window-test
branch
from
e07bdbb
to
77956c7
Compare
michaelmdresser
force-pushed
the
mmd/fix-window-test
branch
from
77956c7
to
af870f1
Compare
Sean-Holcomb
approved these changes
Jan 9, 2024
We were assuming that the library always returns seconds, but it can now also return minutes (presumably if the seconds divide well). This is probably failing due to an update of that library. Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
michaelmdresser
force-pushed
the
mmd/fix-window-test
branch
from
af870f1
to
f3f9569
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
We were assuming that the library always returns seconds, but it can now also return minutes (presumably if the seconds divide well). This is probably failing due to an update of that library.
How will this PR impact users?
How was this PR tested?