You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR introduces the ability to enforce the use of a custom pricing provider in OpenCost when deployed on GCP or other public cloud Kubernetes clusters. Previously, deploying on these platforms automatically defaulted to their respective public cloud providers, requiring API keys for pricing information. Now, users can activate a custom provider by setting USE_CUSTOM_PROVIDER=true, enabling custom pricing without the need for API keys.
Does this PR relate to any other PRs?
No
How will this PR impact users?
This change affects users who opt to use the custom provider feature by setting the environment variable USE_CUSTOM_PROVIDER=true in the OpenCost container.
Allows greater flexibility and control over pricing data sources, particularly beneficial for users who prefer not to use public cloud provider API keys.
Does this PR address any GitHub or Zendesk issues?
Tested using a custom OpenCost image (ghcr.io/janlauber/opencost:v1.109.0) deployed in a GCP cluster, confirming the ability to utilize custom pricing with USE_CUSTOM_PROVIDER set to "true".
Does this PR require changes to documentation?
I think not, but it would be nice to set a note anywhere
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?
@janlauber So the intended effect here is that if the user specifies USE_CUSTOM_PROVIDER=true and are not using a CSV provider, then OpenCost will default to using the pricing found in default.json?
mattray
added
opencost
OpenCost issues vs. external/downstream
P2
Estimated Priority (P0 is highest, P4 is lowest)
kubecost
Relevant to Kubecost's downstream project
E2
Estimated level of Effort (1 is easiest, 4 is hardest)
labels
Jan 16, 2024
The reason will be displayed to describe this comment to others. Learn more.
This seems logical, but I'd like to hear Sean's thoughts. I also just approved this PR to run CI, so we want to make sure that passes too (I assume it will).
This pull request has been marked as stale because it has been open for 90 days with no activity. Please remove the stale label or comment or this pull request will be closed in 5 days.
E2Estimated level of Effort (1 is easiest, 4 is hardest)kubecostRelevant to Kubecost's downstream projectneeds-follow-upopencostOpenCost issues vs. external/downstreamP2Estimated Priority (P0 is highest, P4 is lowest)
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR change?
This PR introduces the ability to enforce the use of a custom pricing provider in OpenCost when deployed on GCP or other public cloud Kubernetes clusters. Previously, deploying on these platforms automatically defaulted to their respective public cloud providers, requiring API keys for pricing information. Now, users can activate a custom provider by setting
USE_CUSTOM_PROVIDER=true, enabling custom pricing without the need for API keys.Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Tested using a custom OpenCost image (
ghcr.io/janlauber/opencost:v1.109.0) deployed in a GCP cluster, confirming the ability to utilize custom pricing withUSE_CUSTOM_PROVIDERset to "true".Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?