Opencost Core Refactor #2440
Merged
Opencost Core Refactor #2440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
mbolt35
commented
Jan 8, 2024
mbolt35
commented
Jan 8, 2024
mbolt35
commented
Jan 8, 2024
mbolt35
commented
Jan 8, 2024
|
@bolt given everything is moving right now and this move is bound to break people, it seems like now would be a good time to remove the name kubecost from the pkg name. What do you think? |
Not to say it should be this PR necessarily but flagging that both should land in the same release to prevent a double move for external users |
Sean-Holcomb
approved these changes
Jan 13, 2024
mbolt35
force-pushed
the
bolt/opencost-core
branch
from
c7932dc
to
000010a
Compare
nikovacevic
approved these changes
Jan 16, 2024
* Add ReadLocked and WriteLocked to fileutil Signed-off-by: Michael Dresser <michaelmdresser@gmail.com> * Use locking r/w in FileStorage This is necessary as we plan to use multiple processes with this library accessing files on the same filesystem. Signed-off-by: Michael Dresser <michaelmdresser@gmail.com> * Add FD-based flock()-ed read and write Signed-off-by: Michael Dresser <michaelmdresser@gmail.com> * Move file lock code to separate file Signed-off-by: Michael Dresser <michaelmdresser@gmail.com> * Make locks unimplemented for Windows This should allow Windows users to still import Opencost but functionality which requires these functions will not work. This should have minimal impact. Refer to the following when wishing to implement for windows: - https://github.com/golang/go/blob/master/src/cmd/go/internal/lockedfile/internal/filelock/filelock_windows.go - maybe also https://github.com/gofrs/flock/blob/master/flock_windows.go Signed-off-by: Michael Dresser <michaelmdresser@gmail.com> * Unlock after failed read and write Signed-off-by: Michael Dresser <michaelmdresser@gmail.com> * Add further unit test Signed-off-by: Michael Dresser <michaelmdresser@gmail.com> * Make r/w locked robust to FD position Signed-off-by: Michael Dresser <michaelmdresser@gmail.com> --------- Signed-off-by: Michael Dresser <michaelmdresser@gmail.com> Signed-off-by: Matt Bolt <mbolt35@gmail.com>
… First pass at unifying filters Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Sachin Kumar <sachin@rafay.co> Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Sachin Kumar <sachin@rafay.co> Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Sachin Kumar <sachin@rafay.co> Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Sachin Kumar <sachin@rafay.co> Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Niko Kovacevic <nikovacevic@gmail.com> Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Matt Bolt <mbolt35@gmail.com>
mbolt35
force-pushed
the
bolt/opencost-core
branch
from
017dd62
to
67fdc24
Compare
mattray
reviewed
Jan 17, 2024
mattray
reviewed
Jan 17, 2024
mattray
approved these changes
Jan 17, 2024
Signed-off-by: Matt Bolt <mbolt35@gmail.com>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major Changes
This refactor is focusing on a few main concerns revolving around filters, legacy filters, and unification around the current implementation. It separates an easier to consume module for external projects which reference opencost for the models and/or utilities.
Opencost Core Module
Created a new go module under the
core/directory which will now contain sharable opencost code:corecoreenvare moved tocoreFilter Unification
core/pkg/filter-- legacy filtering support will temporarily be supported during this process undercore/pkg/filter/legacyRequire Answers
go.modwas created for the module:github.com/opencost/opencost/coreand the opencostgo.moduses:to ensure that both modules are still "versioned" together. However, it's unclear if this method of replacement is the correct convention for long term maintenance.