Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cross-Zone and Cross-Region Network Costs Labels #2478

Merged
merged 1 commit into from Jan 29, 2024
Merged

Cross-Zone and Cross-Region Network Costs Labels #2478

merged 1 commit into from Jan 29, 2024

Conversation

mbolt35
Copy link
Contributor

@mbolt35 mbolt35 commented Jan 27, 2024

What does this PR change?

  • This PR updates the labels queried in opencost to match the updated network-costs deployment. This fixes a bug that has been outstanding since the network-costs 0.17.0 release.

How will this PR impact users?

  • This will fix allocation numbers for cross-zone and cross-region network costs.

Does this PR address any GitHub or Zendesk issues?

@vercel Vercel
Copy link

vercel bot commented Jan 27, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 29, 2024 8:43pm

@mbolt35 mbolt35 self-assigned this Jan 27, 2024
@mbolt35 @michaelmdresser
Update network-costs metric labels for tracking cross-zone and cross-…
8d47e27 
…region traffic counts

Signed-off-by: Matt Bolt <mbolt35@gmail.com>
@michaelmdresser michaelmdresser merged commit e178fc8 into develop Jan 29, 2024
8 checks passed
@michaelmdresser michaelmdresser deleted the bolt/update-netcosts-metric branch January 29, 2024 20:46
michaelmdresser pushed a commit that referenced this pull request Jan 29, 2024
@mbolt35 @michaelmdresser
Update network-costs metric labels for tracking cross-zone and cross-…
1c16e7c 
…region traffic counts (#2478)

Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
@michaelmdresser michaelmdresser mentioned this pull request Jan 29, 2024
Merged
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Jan 29, 2024

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

michaelmdresser added a commit that referenced this pull request Jan 29, 2024
@michaelmdresser @mbolt35
Update network-costs metric labels for tracking cross-zone and cross-…
099faaf 
…region traffic counts (#2478) (#2485)

Signed-off-by: Matt Bolt <mbolt35@gmail.com>
Signed-off-by: Michael Dresser <michaelmdresser@gmail.com>
Co-authored-by: Matt Bolt <mbolt35@gmail.com>
@mbolt35 mbolt35 mentioned this pull request Feb 1, 2024
Open
2 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AjayTripathy AjayTripathy AjayTripathy approved these changes

@michaelmdresser michaelmdresser michaelmdresser approved these changes

Assignees

@mbolt35 mbolt35

Labels
needs-follow-up
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mbolt35 @AjayTripathy @michaelmdresser