Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use policy/v1 for PodDisruptionBudget #2499

Merged
merged 1 commit into from Feb 5, 2024

Conversation

a7i
Copy link
Contributor

@a7i a7i commented Feb 3, 2024

What does this PR change?

  • uses policy/v1 for listing PDBs

Does this PR relate to any other PRs?

  • No

How will this PR impact users?

  • policy/v1beta1 is no longer served as of 1.25

Does this PR address any GitHub or Zendesk issues?

  • Closes ...

How was this PR tested?

Does this PR require changes to documentation?

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

Copy link

vercel bot commented Feb 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 5, 2024 6:13pm

@mattray mattray added opencost OpenCost issues vs. external/downstream P1 Estimated Priority (P0 is highest, P4 is lowest) kubecost Relevant to Kubecost's downstream project E2 Estimated level of Effort (1 is easiest, 4 is hardest) labels Feb 5, 2024
@mattray
Copy link
Collaborator

mattray commented Feb 5, 2024

@a7i thanks for opening this! Looking at the Kubernetes API documentation I see this API was removed in 1.25 and available since 1.21. This means we should update
https://www.opencost.io/docs/installation/install
and Kubecost should update
https://docs.kubecost.com/install-and-configure/install/environment#supported-kubernetes-versions
accordingly.

Copy link
Collaborator

@mattray mattray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I want another @opencost/opencost-maintainers to merge it, but it looks good to me.

Copy link
Contributor

@michaelmdresser michaelmdresser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If I'm reading K8s notes correctly, policy/v1 PodDisruptionBudget was added in K8s v1.21 (https://github.com/kubernetes/sig-release/blob/master/releases/release-1.21/release-notes/release-notes-draft.md). I think that's enough prior versions of support for us to roll forward with only supporting policy/v1 PDBs.

EDIT: Matt, I can't read. Thank you for doing the research.

Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
@michaelmdresser
Copy link
Contributor

Hey @AjayTripathy -- heads up that this will bump KC's min K8s version from v1.20 to v1.21, but I think it might only affect Spot Commander.

@michaelmdresser michaelmdresser merged commit 0168166 into opencost:develop Feb 5, 2024
5 checks passed
Copy link

sonarcloud bot commented Feb 5, 2024

@a7i a7i deleted the policy-v1-pdb branch February 5, 2024 18:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E2 Estimated level of Effort (1 is easiest, 4 is hardest) kubecost Relevant to Kubecost's downstream project needs-follow-up opencost OpenCost issues vs. external/downstream P1 Estimated Priority (P0 is highest, P4 is lowest)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants