-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
use policy/v1
for PodDisruptionBudget
#2499
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@a7i thanks for opening this! Looking at the Kubernetes API documentation I see this API was removed in 1.25 and available since 1.21. This means we should update |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I want another @opencost/opencost-maintainers to merge it, but it looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If I'm reading K8s notes correctly, policy/v1
PodDisruptionBudget
was added in K8s v1.21 (https://github.com/kubernetes/sig-release/blob/master/releases/release-1.21/release-notes/release-notes-draft.md). I think that's enough prior versions of support for us to roll forward with only supporting policy/v1 PDBs.
EDIT: Matt, I can't read. Thank you for doing the research.
Signed-off-by: Amir Alavi <amiralavi7@gmail.com>
3077adc
to
9358f73
Compare
Hey @AjayTripathy -- heads up that this will bump KC's min K8s version from v1.20 to v1.21, but I think it might only affect Spot Commander. |
Quality Gate passedKudos, no new issues were introduced! 0 New issues |
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?