Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: opencost-helm-chart #176 issue consistent prometheus namespaceName and serviceName #2519

Merged

Conversation

brito-rafa
Copy link
Contributor

@brito-rafa brito-rafa commented Feb 8, 2024

What does this PR change?

  • Addresses issue #176, making prometheus installation example and configuration consistent across the manifests, helm and documentation. Using namespace prometheus-system and service name prometheus-server with release name prometheus.

Does this PR relate to any other PRs?

  • No

How will this PR impact users?

  • Helm users will not be impacted since we are favoring helm default configuration. Users that used the manifests to install, most likely will not use them for upgrade.

Does this PR address any GitHub or Zendesk issues?

  • Closes 176

How was this PR tested?

  • On a local kind cluster.

Does this PR require changes to documentation?

  • Yes, there is a separate PR for such.

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

  • This is a more house cleaning item than a bug.

Signed-off-by: Rafael Brito <rafa@stormforge.io>
Copy link

vercel bot commented Feb 8, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 8, 2024 8:28pm

@brito-rafa brito-rafa changed the title chore: #176 consistent prometheus namespaceName and serviceName chore: opencost-helm-chart #176 issue consistent prometheus namespaceName and serviceName Feb 8, 2024
@mattray mattray merged commit 24ef3a6 into opencost:develop Feb 9, 2024
4 of 5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants