Allow opencost-ui to run with a read-only root filesystem #2521
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Kai Timmer <email@kaitimmer.de>
kaitimmer
force-pushed
the
allow-readonly-root-filesytem
branch
from
28b8b93
to
ba67364
Compare
Signed-off-by: Kai Timmer <kai@staffbase.com>
mattray
added
opencost
|
@kaitimmer thanks for the submission. I'll test it and verify it doesn't cause a regression |
This was referenced Mar 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Allow to run with a read-only root file system.
This is important for people who need to run this in Kubernetes with a policy set that only allows pods that have this set:
Does this PR relate to any other PRs?
No
How will this PR impact users?
It does not directly affect users. The container continues to run with the same behavior as before. The only difference is, that now one can mount an emptyDir to /var/www and have the root filesystem read-only.
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Setting this in the Helm charts as a default would be possible. I guess that would make sense from a security point of view.