Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for showing "__idle__" in the UI #2557

Merged
merged 2 commits into from Feb 21, 2024
Merged

Conversation

mattray
Copy link
Collaborator

@mattray mattray commented Feb 21, 2024

What does this PR change?

  • Adds __idle__ field to UI reports on usage, showing what's not currently in use by the cluster. These values were in the API, just not rendered.

Does this PR relate to any other PRs?

  • No

How will this PR impact users?

  • Users will now have more accurate results when comparing to their cloud bills.

Does this PR address any GitHub or Zendesk issues?

How was this PR tested?

  • Locally and with GKE

Does this PR require changes to documentation?

  • No

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

  • This will be called out when released, since it's a change in behavior

Signed-off-by: Matt Ray <github@mattray.dev>
Copy link

vercel bot commented Feb 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 21, 2024 11:13pm

@mattray mattray added opencost OpenCost issues vs. external/downstream P2 Estimated Priority (P0 is highest, P4 is lowest) E1 Estimated level of Effort (1 is easiest, 4 is hardest) and removed needs-follow-up labels Feb 21, 2024
@mattray mattray merged commit 05110a9 into opencost:develop Feb 21, 2024
3 of 4 checks passed
Copy link

sonarcloud bot commented Feb 21, 2024

@mattray mattray deleted the idle branch February 22, 2024 00:44
@danijam
Copy link

danijam commented Mar 11, 2024

Hey @mattray, I found this via #2162. I see 1.109.0 was released on 6th March. This PR was merged on 21st Feb. I can't see it mentioned on the release details. Did it miss the 1.109.0 release?

@mattray
Copy link
Collaborator Author

mattray commented Mar 13, 2024

The 1.109 branch was made before the merge, so it will be in the upcoming 1.110 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E1 Estimated level of Effort (1 is easiest, 4 is hardest) needs-follow-up opencost OpenCost issues vs. external/downstream P2 Estimated Priority (P0 is highest, P4 is lowest)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants