Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pod cache initialization #2576

Merged
merged 2 commits into from Feb 28, 2024
Merged

Conversation

r2k1
Copy link
Contributor

@r2k1 r2k1 commented Feb 27, 2024

What does this PR change?

Looks like due to the typo podWatch has been initialized twice and poddisruptionbudgets has not been initialized.

This caused requesting list of all pods during initialization.

Signed-off-by: r2k1 <yokree@gmail.com>
Copy link

vercel bot commented Feb 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2024 6:08pm

Copy link
Collaborator

@mattray mattray left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@r2k1 thanks!

@mattray mattray added opencost OpenCost issues vs. external/downstream P2 Estimated Priority (P0 is highest, P4 is lowest) kubecost Relevant to Kubecost's downstream project E1 Estimated level of Effort (1 is easiest, 4 is hardest) labels Feb 27, 2024
@AjayTripathy AjayTripathy merged commit b3ac7e2 into opencost:develop Feb 28, 2024
4 of 5 checks passed
Copy link

sonarcloud bot commented Feb 28, 2024

@worr
Copy link

worr commented Apr 9, 2024

@mattray Hey! Sorry to bother you, is there any chance that this will make it into the v1 line of releases? I see it's in several v2 releases

@mattray
Copy link
Collaborator

mattray commented Apr 10, 2024

sorry for the confusion, the v2 releases are Kubecost's tags and unrelated to the v1.x series of OpenCost. We're sorting those out and this was committed to the develop branch, which will be branched soon for the 1.110.0 release

@worr
Copy link

worr commented Apr 10, 2024

Thanks for clearing up the confusion; looking forward to the next release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
E1 Estimated level of Effort (1 is easiest, 4 is hardest) kubecost Relevant to Kubecost's downstream project needs-follow-up opencost OpenCost issues vs. external/downstream P2 Estimated Priority (P0 is highest, P4 is lowest)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants