minor consistency update for node's well known labels #2605
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: jasonz <ksdpmx@gmail.com>
|
Thanks for the PR @ksdpmx! Any @opencost/opencost-maintainers want to weigh in on any reason not to merge this? |
|
Thanks for the contribution @ksdpmx ! For other reviewers, here are the values for these consts: It looks like some of the test cases were updated to use the correct up to date values, but I think we intended to mix legacy constants and current stable constants in order to test the compatibility layer. I think having up to date constant values is probably fine and shouldn't block this PR. Would love at least one other maintainer to verify! |
mbolt35
approved these changes
Mar 5, 2024
|
AjayTripathy
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
go testDoes this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?