Nik/plugins #2619
Merged
Nik/plugins #2619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
ameijer
approved these changes
Mar 8, 2024
| cc.BilledCost += other.BilledCost | ||
| cc.ListCost += other.ListCost | ||
| cc.ListUnitPrice += other.ListUnitPrice | ||
| cc.UsageQuantity += other.UsageQuantity |
There was a problem hiding this comment.
the only major thing I see in this PR is that when adding, we should take the intersection of the string properties. so if one domain != another domain, then the result is the domain is an empty string, that more closely matches our existing logic
There was a problem hiding this comment.
When this goes into the working branch, I will fix this unless @nik-kc hits this before the merge
cliffcolvin
approved these changes
Mar 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?