-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
provide default accumulation for custom costs API #2630
provide default accumulation for custom costs API #2630
Conversation
Signed-off-by: Alex Meijer <ameijer@kubecost.com>
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
} | ||
|
||
// GetCustomCostAccumulateOption determines defaults in a way that matches options presented in the UI | ||
func getCustomCostAccumulateOption(window opencost.Window, from []opencost.AccumulateOption) (opencost.AccumulateOption, error) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appears unit test-worthy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
added!
Signed-off-by: Alex Meijer <ameijer@kubecost.com>
…into atm/default-accum-opts Signed-off-by: Alex Meijer <ameijer@kubecost.com>
@michaelmdresser I added a unit test - would you be able to merge this? |
Quality Gate passedIssues Measures |
What does this PR change?
Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?