Add carbon estimation functionality to assets #2653
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Signed-off-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com>
Signed-off-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com>
kaelanspatel
force-pushed
the
kaelan-carbon-assets
branch
from
083fe94
to
369c8f8
Compare
| w.Write(WrapData(carbonEstimates, nil)) | ||
| } | ||
|
|
||
| func (a *Accesses) computeAssetsFromCostmodel(window opencost.Window, filterString string) (*opencost.AssetSet, error) { |
There was a problem hiding this comment.
This is an excellent change regardless
Signed-off-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com>
michaelmdresser
approved these changes
Mar 19, 2024
|
nik-kc
pushed a commit
to nik-kc/opencost
that referenced
this pull request
Apr 4, 2024
* Simple preliminary framework for carbon assets Signed-off-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> * Fix cost using whole window instead of active mins Signed-off-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> * change carbon lookup struct + cleanup Signed-off-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> --------- Signed-off-by: Kaelan Patel <32113845+kaelanspatel@users.noreply.github.com> Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
Adds carbon estimation functionality to Opencost
/assets, assigning a carbon cost in CO2e to each node/disk based off a lookup table.Enabled by setting the
CARBON_ESTIMATES_ENABLEDenv var.Does this PR relate to any other PRs?
No.
How will this PR impact users?
/assets/carbonendpoint to Opencost, allowing users to see carbon costs for node and disk assets.Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?
Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?