Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Custom Cost window and step calculations #2671

Merged
merged 1 commit into from Mar 27, 2024

Conversation

nik-kc
Copy link
Contributor

@nik-kc nik-kc commented Mar 27, 2024

What does this PR change?

  • Fixes the calculations used to determine windows and accumulations for Custom Cost queries.
  • Exposes these fixed calculations for use by KCM.

Does this PR relate to any other PRs?

How will this PR impact users?

  • Custom Cost queries for windows of e.g. 48h will show matching and complete time series and totals data.

Does this PR address any GitHub or Zendesk issues?

How was this PR tested?

  • Tested locally against Kubecost Datadog data:
    • Verified that /customCost/total and /customCost/timeseries` responses contained matching and complete cost data for windows that use both hourly and daily data stores:
      • 24h
      • 48h
      • 1d
      • 3d
      • 7d
      • 30d

Does this PR require changes to documentation?

  • Nope.

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

  • v2.2

Copy link

vercel bot commented Mar 27, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 27, 2024 8:37pm

Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
Copy link

sonarcloud bot commented Mar 27, 2024

@cliffcolvin cliffcolvin merged commit 20b024f into opencost:develop Mar 27, 2024
7 checks passed
@nik-kc nik-kc mentioned this pull request Mar 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants