-
Notifications
You must be signed in to change notification settings - Fork 515
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add domains
to /customCost/status
response
#2676
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
nik-kc
changed the title
Add
Add Mar 29, 2024
domains
to /customCost/status
resopnsedomains
to /customCost/status
response
cliffcolvin
approved these changes
Mar 29, 2024
…lugin domains. Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
nik-kc
force-pushed
the
nik/custom_costs
branch
from
March 29, 2024 21:03
2b703d2
to
e4d9865
Compare
Quality Gate passedIssues Measures |
nik-kc
added a commit
to nik-kc/opencost
that referenced
this pull request
Mar 29, 2024
* Updated /customCost/status to include the list of currently enabled plugin domains. Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com> * Updated plugin parser to ignore hidden files and directories. Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com> --------- Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
cliffcolvin
pushed a commit
that referenced
this pull request
Mar 29, 2024
* Updated /customCost/status to include the list of currently enabled plugin domains. * Updated plugin parser to ignore hidden files and directories. --------- Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
nik-kc
added a commit
to nik-kc/opencost
that referenced
this pull request
Apr 4, 2024
…ost#2677) * Updated /customCost/status to include the list of currently enabled plugin domains. * Updated plugin parser to ignore hidden files and directories. --------- Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR change?
/customCost/status
response to include the list of currently enabled Custom Cost plugins.Does this PR relate to any other PRs?
How will this PR impact users?
Does this PR address any GitHub or Zendesk issues?
How was this PR tested?
Does this PR require changes to documentation?