Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add domains to /customCost/status response #2676

Merged
merged 2 commits into from Mar 29, 2024

Conversation

nik-kc
Copy link
Contributor

@nik-kc nik-kc commented Mar 29, 2024

What does this PR change?

  • Updates the /customCost/status response to include the list of currently enabled Custom Cost plugins.

Does this PR relate to any other PRs?

How will this PR impact users?

  • Custom Cost pages in the FE will be able to reliably determine if Custom Costs are enabled.

Does this PR address any GitHub or Zendesk issues?

  • Nope.

How was this PR tested?

  • To be tested.

Does this PR require changes to documentation?

  • Nope.

Copy link

vercel bot commented Mar 29, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
opencost ✅ Ready (Inspect) Visit Preview 💬 Add feedback Mar 29, 2024 9:04pm

@nik-kc nik-kc changed the title Add domains to /customCost/status resopnse Add domains to /customCost/status response Mar 29, 2024
…lugin domains.

Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
@cliffcolvin cliffcolvin merged commit 059af4e into opencost:develop Mar 29, 2024
6 checks passed
Copy link

sonarcloud bot commented Mar 29, 2024

nik-kc added a commit to nik-kc/opencost that referenced this pull request Mar 29, 2024
* Updated /customCost/status to include the list of currently enabled plugin domains.

Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>

* Updated plugin parser to ignore hidden files and directories.

Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>

---------

Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
cliffcolvin pushed a commit that referenced this pull request Mar 29, 2024
* Updated /customCost/status to include the list of currently enabled plugin domains.



* Updated plugin parser to ignore hidden files and directories.



---------

Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
nik-kc added a commit to nik-kc/opencost that referenced this pull request Apr 4, 2024
…ost#2677)

* Updated /customCost/status to include the list of currently enabled plugin domains.

* Updated plugin parser to ignore hidden files and directories.

---------

Signed-off-by: Nik Willwerth <nwillwerth@kubecost.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants