Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update logging & comments in CostModelMetricsEmitter #2756

Merged
merged 3 commits into from
May 23, 2024

Conversation

thomasvn
Copy link
Contributor

What does this PR change?

  • Comments & logging. Bump some logs down to trace. Include more details in log lines regarding ondemand pricing data.

Does this PR relate to any other PRs?

  • N/A

How will this PR impact users?

  • N/A

Does this PR address any GitHub or Zendesk issues?

  • N/A

How was this PR tested?

  • N/A

Does this PR require changes to documentation?

  • N/A

Have you labeled this PR and its corresponding Issue as "next release" if it should be part of the next OpenCost release? If not, why not?

  • N/A

Signed-off-by: thomasvn <thomasnguyen96@gmail.com>
@thomasvn thomasvn marked this pull request as ready for review May 21, 2024 22:04
Copy link
Member

@cliffcolvin cliffcolvin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mattray mattray merged commit 26fa93c into opencost:develop May 23, 2024
3 checks passed
@thomasvn thomasvn deleted the thomasn/gpu-ondemand branch May 23, 2024 14:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants