Ajay tripathy fix historical #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mdaniel
reviewed
May 1, 2019
cloud/gcpprovider.go
Outdated
| for k, key := range inputKeys { | ||
| if key.GPUType() == gpuType { | ||
| if region == strings.Split(k, ",")[0] { | ||
| klog.V(3).Infof("MATCHED GPU TO NODE in region " + region) |
main.go
Outdated
| w.Write(wrapData(data, err)) | ||
| err = p.Cloud.DownloadPricingData() | ||
| if err != nil { | ||
| klog.V(1).Infof("Error redownloading data on config update") |
There was a problem hiding this comment.
Please don't swallow errors -- the first thing anyone who sees this message will want to know is what was the error while redownloading ...
| provIdRx := regexp.MustCompile("(Nvidia Tesla [^ ]+) ") | ||
| for matchnum, group := range provIdRx.FindStringSubmatch(product.Description) { | ||
| if matchnum == 1 { | ||
| gpuType = strings.ToLower(strings.Join(strings.Split(group, " "), "-")) |
There was a problem hiding this comment.
for your consideration, it's quite strange to use a regex, with a grouping construct, and then use some split-join magic to extract the thing one actually cares about from that string
cloud/gcpprovider.go
Outdated
| @@ -435,6 +520,11 @@ func (gcp *gcpKey) Features() string { | |||
| } else { | |||
| usageType = "ondemand" | |||
| } | |||
|
|
|||
| if _, ok := gcp.Labels["cloud.google.com/gke-accelerator"]; ok { | |||
There was a problem hiding this comment.
Making this a constant would likely go a long way toward avoiding updated-in-one-place-but-not-the-other bugs
cloud/awsprovider.go
Outdated
| @@ -76,6 +76,8 @@ type AWSProductAttributes struct { | |||
| UsageType string `json:"usagetype"` | |||
| OperatingSystem string `json:"operatingSystem"` | |||
| PreInstalledSw string `json:"preInstalledSw"` | |||
| InstanceFamily string `json:"instanceFamily"` | |||
| GPU string `json:gpu` | |||
There was a problem hiding this comment.
It would be outstanding if this carried some godoc, since GPU of type string could be anything
Same thing fro its GPU string friend in the GCP version below
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #62 -- mostly. If the node has disappeared, you would need to examine the pricing data from the emitted /metrics endpoint.
Also adds better GPU support.