Fix long overflow by specifying getting state upto Instant.now() #18
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found this few weeks back when I was doing something similar to the
concursus-spring-boot-demo
app. Then I saw someone has the same problem as reported in issue #17The problem is quite straightforward, when we call
groupStateRepository.getStates(groups)
in test code, it in turn callsgetState(groups, Instant.MAX)
, whereInstant.MAX
is the upper bound. Later on when inCassandraEventRetriever.constrainBound
, it callsbound.getInstant().toEpochMilli())
which results in the long overflow exception.The problem can be simply reproduced by
Instant.MAX.toEpochMilli())
Anyways, I'm not sure if
Instant.MAX
is intended. From the code comments, it seems to beInstant.now()
, which translates to "get the events up to now". whereasInstant.MAX
means to the far future based on its own documentation.At the meantime, a simple workaround (as currently what i'm doing) is to specify the upper bound (i.e. do
groupStateRepository.getStates(groups, Instant.now())
instead). The error goes away