Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes max-width on fields #3067

Merged
merged 2 commits into from May 16, 2022
Merged

removes max-width on fields #3067

merged 2 commits into from May 16, 2022

Conversation

jpye-finch
Copy link
Collaborator

@jpye-finch jpye-finch commented May 13, 2022

  • removes max-width on Input field. That cause ui issues with radio buttons.
  • sets width of text input to 344px

image

image

image

@codecov
Copy link

codecov bot commented May 13, 2022

Codecov Report

Merging #3067 (2ce3b4a) into develop (f10f764) will decrease coverage by 0.01%.
The diff coverage is 64.36%.

❗ Current head 2ce3b4a differs from pull request most recent head 691e06d. Consider uploading reports for the commit 691e06d to get more accurate results

@@             Coverage Diff             @@
##           develop    #3067      +/-   ##
===========================================
- Coverage    77.31%   77.29%   -0.02%     
===========================================
  Files          597      597              
  Lines        27633    27638       +5     
  Branches      8818     8821       +3     
===========================================
  Hits         21364    21364              
- Misses        6227     6232       +5     
  Partials        42       42              
Impacted Files Coverage Δ
.../client/src/components/interface/Header/Header.tsx 73.12% <ø> (ø)
packages/client/src/declarations/index.ts 75.34% <0.00%> (-0.15%) ⬇️
packages/client/src/forms/configuration/default.ts 0.00% <ø> (ø)
packages/client/src/forms/configuration/index.ts 51.42% <0.00%> (ø)
packages/client/src/i18n/messages/constants.ts 100.00% <ø> (ø)
packages/client/src/profile/profileReducer.ts 83.58% <ø> (-0.48%) ⬇️
packages/client/src/utils/userUtils.ts 93.75% <ø> (ø)
packages/client/src/views/Home/RecordAudit.tsx 59.11% <0.00%> (ø)
...ackages/client/src/views/OfficeHome/OfficeHome.tsx 53.16% <ø> (ø)
.../SysAdmin/Config/Forms/Wizard/FormConfigWizard.tsx 7.59% <0.00%> (ø)
... and 24 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update da563c6...691e06d. Read the comment docs.

@rikukissa rikukissa enabled auto-merge (squash) May 16, 2022 08:43
@rikukissa rikukissa merged commit 327ec0b into develop May 16, 2022
@euanmillar euanmillar deleted the field-widths branch October 18, 2022 14:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants