Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precommit hook #49

Merged
merged 2 commits into from May 30, 2018
Merged

Fix precommit hook #49

merged 2 commits into from May 30, 2018

Conversation

rikukissa
Copy link
Collaborator

Still not entirely sure what was happening, but I'd imagine it was a husky configuration error which led into Husky defaulting to npm run test, which was then again handled by Lerna.

Got --watchAll=false from here:
facebook/create-react-app#784 (comment)

Copy link
Contributor

@rcrichton rcrichton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rcrichton rcrichton merged commit f5ef897 into master May 30, 2018
@rcrichton rcrichton deleted the update-husky branch May 30, 2018 13:34
gitbook-com bot pushed a commit that referenced this pull request Jun 1, 2022
gitbook-com bot pushed a commit that referenced this pull request Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants