Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ocrvs-6469 include middlename when generating fullnames #6576

Merged
merged 11 commits into from
Mar 6, 2024

Conversation

Zangetsu101
Copy link
Collaborator

No description provided.

@Zangetsu101 Zangetsu101 added 💅 Waiting For Review 💥 Hot Fixes Hot fixes for (prod/qa/staging) deployment labels Mar 4, 2024
Copy link

codecov bot commented Mar 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.15%. Comparing base (6de4a55) to head (f268730).
Report is 7 commits behind head on release-v1.3.4.

❗ Current head f268730 differs from pull request most recent head 39d21fa. Consider uploading reports for the commit 39d21fa to get more accurate results

Additional details and impacted files
@@                Coverage Diff                 @@
##           release-v1.3.4    #6576      +/-   ##
==================================================
- Coverage           86.33%   86.15%   -0.19%     
==================================================
  Files                 728      728              
  Lines              127337   127230     -107     
  Branches            12036    11987      -49     
==================================================
- Hits               109942   109614     -328     
- Misses              17390    17611     +221     
  Partials                5        5              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rikukissa
Copy link
Collaborator

Looks good to me. @Zangetsu101 merge when you're finished with this.

@rikukissa rikukissa added 👌 LGTM and removed 💅 Waiting For Review 💥 Hot Fixes Hot fixes for (prod/qa/staging) deployment labels Mar 5, 2024
@Zangetsu101 Zangetsu101 merged commit 6957be3 into release-v1.3.4 Mar 6, 2024
1 check passed
@Zangetsu101 Zangetsu101 deleted the ocrvs-6469-fix branch March 6, 2024 06:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants