curvefs/client: fixed some minor bugs.

Signed-off-by: Wine93 <wine93.info@gmail.com>
opencurve · Jun 9, 2023 · d2e018e · d2e018e
1 parent 1279ee9
commit d2e018e
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 8 deletions.
diff --git a/curvefs/conf/client.conf b/curvefs/conf/client.conf
@@ -135,14 +135,14 @@ fuseClient.throttle.burstReadIopsSecs=180
 #### filesystem metadata
 # {
 # fs.disableXattr:
-#   if you want to get curvefs specified xattr,
-#   you can mount another fs with |fs.disableXattr| is true
+#   if you want to get better metadata performance,
+#   you can mount fs with |fs.disableXattr| is true
 #
 # fs.lookupCache.negativeTimeoutSec:
 #   entry which not found will be cached if |timeout| > 0
 fs.cto=true
 fs.maxNameLength=255
-fs.disableXattr=true
+fs.disableXattr=false
 fs.accessLogging=true
 fs.kernelCache.attrTimeoutSec=3600
 fs.kernelCache.dirAttrTimeoutSec=3600

diff --git a/curvefs/src/client/filesystem/rpc_client.cpp b/curvefs/src/client/filesystem/rpc_client.cpp
@@ -104,9 +104,11 @@ CURVEFS_ERROR RPCClient::ReadDir(Ino ino,
             continue;
         }
 
+        // NOTE: we can't use std::move() for attribute for hard link
+        // which will sharing inode attribute.
         dirEntry.ino = ino;
         dirEntry.name = std::move(dentry.name());
-        dirEntry.attr = std::move(iter->second);
+        dirEntry.attr = iter->second;
         (*entries)->Add(dirEntry);
     }
     return CURVEFS_ERROR::OK;

diff --git a/curvefs/src/client/fuse_client.cpp b/curvefs/src/client/fuse_client.cpp
@@ -185,6 +185,7 @@ CURVEFS_ERROR FuseClient::Init(const FuseClientOption &option) {
     }
 
     InitQosParam();
+    fs_->Run();
 
     return CURVEFS_ERROR::OK;
 }
@@ -368,10 +369,7 @@ CURVEFS_ERROR FuseClient::UpdateParentMCTimeAndNlink(
         if (option_.fileSystemOption.deferSyncOption.deferDirMtime) {
             inodeManager_->ShipToFlush(parentInodeWrapper);
         } else {
-            ret = parentInodeWrapper->SyncAttr();
-            if (ret != CURVEFS_ERROR::OK) {
-                return CURVEFS_ERROR::OK;
-            }
+            return parentInodeWrapper->SyncAttr();
         }
     }