Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[skipci] doc: add space manage of curvefs with volume backend #2294

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

ilixiaocui
Copy link
Contributor

@ilixiaocui ilixiaocui commented Mar 7, 2023

What problem does this PR solve?

Issue Number: #2160

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@ilixiaocui ilixiaocui force-pushed the master branch 4 times, most recently from 57a781a to c9f883e Compare March 8, 2023 12:42
- 不需要全部遍历所有的 InodeId, 清理效率会大大提高

缺点:
- 三副本上需要同步这一信息,因此 InodeId 的持久化需要通过一致性协议,在删除的文件数量很大的情况下,会有比较大的时间开销
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这个持久化,可以在update inode的时候做,不需要额外的走一次一致性协议,时间开销上会增加一次持久化rocksdb的操作,额外增加的时间开销应该还好。

Copy link
Contributor Author

@ilixiaocui ilixiaocui Mar 14, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里不是指删除的时候,是指在数据清理模块,把VolumeExtent对应的BlockGroup的bitmap清理掉后,inode需要更新。这个跟新是需要走一致性协议的。

1. ```Client``` 收到用户删除文件的请求 (空间回收的触发条件1)并处理

- 如果配置了回收站,则把文件放到回收站中(相当于rename的操作)
- 如果没有配置回收站,则直接调用删除Inode的请求
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

client这边是update inode

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

是的

Signed-off-by: ilixiaocui <ilixiaocui@163.com>
… has caused compatibility issues

Signed-off-by: ilixiaocui <ilixiaocui@163.com>
@ilixiaocui ilixiaocui marked this pull request as ready for review July 20, 2023 07:47
@opencurveadmin opencurveadmin merged commit 3cda511 into opencurve:master Jul 20, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants