Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mds/metaserver: Add idle_timeout_sec option #2479

Merged
merged 1 commit into from
Jun 27, 2023

Conversation

201341
Copy link
Contributor

@201341 201341 commented May 12, 2023

What problem does this PR solve?

Add idle_timeout_sec option to reduce server resource

Issue Number: #xxx

Problem Summary:

What is changed and how it works?

What's Changed:

How it Works:

Side effects(Breaking backward compatibility? Performance regression?):

Check List

  • Relevant documentation/comments is changed or added
  • I acknowledge that all my contributions will be made under the project's license

@wuhongsong
Copy link
Contributor

cicheck

@201341
Copy link
Contributor Author

201341 commented May 16, 2023

cicheck

ilixiaocui
ilixiaocui previously approved these changes May 29, 2023
@ilixiaocui ilixiaocui dismissed their stale review May 29, 2023 01:46

Please check where the specific failover of ci is.

@201341
Copy link
Contributor Author

201341 commented May 31, 2023

mds election timeout, it's very strange

@201341
Copy link
Contributor Author

201341 commented Jun 2, 2023

cicheck

@Ziy1-Tan
Copy link
Contributor

Ziy1-Tan commented Jun 5, 2023

mds election timeout, it's very strange

same as #2501. Do you have any idea? @ilixiaocui @201341

@ilixiaocui
Copy link
Contributor

mds election timeout, it's very strange

same as #2501. Do you have any idea? @ilixiaocui @201341

Can you take a screenshot of the failure message?

@ilixiaocui
Copy link
Contributor

This pr involves the management of link methods, and it is necessary to actually test the scope of influence.

@Ziy1-Tan
Copy link
Contributor

Ziy1-Tan commented Jun 6, 2023

mds election timeout, it's very strange

same as #2501. Do you have any idea? @ilixiaocui @201341

Can you take a screenshot of the failure message?

image

@ilixiaocui
Copy link
Contributor

cicheck

2 similar comments
@ilixiaocui
Copy link
Contributor

cicheck

@SeanHai
Copy link
Contributor

SeanHai commented Jun 19, 2023

cicheck

@wuhongsong
Copy link
Contributor

mds election timeout, it's very strange

same as #2501. Do you have any idea? @ilixiaocui @201341

Can you take a screenshot of the failure message?

image

@SeanHai help

@SeanHai
Copy link
Contributor

SeanHai commented Jun 19, 2023

F 2023-06-19T15:46:11.641566+0800 6 configuration.cpp:300] Get mds.server.idleTimeoutSec from /curvefs/mds/conf/mds.conf fail
*** Check failure stack trace: ***
*** Aborted at 1687160771 (unix time) try "date -d @1687160771" if you are using GNU date ***
PC: @ 0x0 (unknown)
*** SIGABRT (@0x6) received by PID 6 (TID 0x7f94b5fcc4c0) from PID 6; stack trace: ***
@ 0x7f94b400d0e0 (unknown)
@ 0x7f94b26c4fff gsignal
@ 0x7f94b26c642a abort
@ 0x55dcdc40492c google::FlushAndAbort()
@ 0x55dcdc401b7e google::LogMessage::Fail()
@ 0x55dcdc401ac7 google::LogMessage::SendToLog()
@ 0x55dcdc4012f0 google::LogMessage::Flush()
@ 0x55dcdc4042c0 google::LogMessageFatal::~LogMessageFatal()
@ 0x55dcdbf59410 curve::common::Configuration::GetValueFatalIfFail()
@ 0x55dcdb739b75 curvefs::mds::MDS::InitOptions()
@ 0x55dcdb73740e main
@ 0x7f94b26b22e1 __libc_start_main
@ 0x55dcdb736c6a _start
@ 0x0 (unknown)

The name in conf is 'mds.server.idleTimeOutSec', but you get in code is 'mds.server.idleTimeoutSec'. Please fix it and retry.

@201341
Copy link
Contributor Author

201341 commented Jun 19, 2023

cicheck

@wuhongsong wuhongsong added the need test Completion of development, requires QA verification label Jun 20, 2023
@wuhongsong
Copy link
Contributor

i will have a test this days.

Signed-off-by: swj <1186093704@qq.com>
@201341
Copy link
Contributor Author

201341 commented Jun 26, 2023

cicheck

@wuhongsong
Copy link
Contributor

Suppressed: hudson.remoting.Channel$CallSiteStackTrace: Remote call to JNLP4-connect connection from , ci failed because of network

@wuhongsong
Copy link
Contributor

cicheck

@wuhongsong
Copy link
Contributor

i will have a test this days.
I have done tests, including functional tests and performance verification, and they are as expected

@wuhongsong wuhongsong merged commit 44949da into opencurve:master Jun 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need test Completion of development, requires QA verification
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants