[feat] add bs status copyset #2520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cicheck |
Cyber-SiKu
force-pushed
the
feat/status/copyset
branch
from
268b859
to
ea11ce5
Compare
Xinlong-Chen
reviewed
Jun 8, 2023
| } | ||
|
|
||
| func (cCmd *CopysetCommand) Init(cmd *cobra.Command, args []string) error { | ||
| config.AddBsFilterOptionFlag(cCmd.Cmd) |
There was a problem hiding this comment.
add flag in
AddFlags?
This is for the called command, not a parameter of the command.
| fmt.Sprintf("--%s", config.CURVEBS_LOGIC_POOL_ID), strings.Join(poolIds, ","), | ||
| }) | ||
|
|
||
| checkRes, err := checkcopyset.GatCopysetsStaus(cCmd.Cmd) |
There was a problem hiding this comment.
GatCopysetsStaus spell error
There was a problem hiding this comment.
GatCopysetsStausspell error
fix
| @@ -167,6 +168,34 @@ func AlignFlagsValue(caller *cobra.Command, callee *cobra.Command, flagNames []s | |||
| } | |||
| } | |||
|
|
|||
| type stringSlice struct { | |||
| value []string | |||
| change bool | |||
There was a problem hiding this comment.
seem useless?
This is to make the flag names of the calling command and the called command consistent, but one is prepared when the string slice and the other is string. There is a problem with the design of pflag, which can be avoided by this method.
There was a problem hiding this comment.
func (s *stringSliceValue) Set(val string) error {
v, err := readAsCSV(val)
if err != nil {
return err
}
if !s.changed {
*s.value = v
} else {
*s.value = append(*s.value, v...)
}
s.changed = true
return nil
}Here is an additional write.
Cyber-SiKu
force-pushed
the
feat/status/copyset
branch
from
ea11ce5
to
2b3cef3
Compare
Xinlong-Chen
approved these changes
Jun 8, 2023
|
cicheck |
Cyber-SiKu
force-pushed
the
feat/status/copyset
branch
from
2b3cef3
to
e6cd8d8
Compare
caoxianfei1
approved these changes
Jun 9, 2023
|
cicheck |
Signed-off-by: Cyber-SiKu <Cyber-SiKu@outlook.com>
Cyber-SiKu
force-pushed
the
feat/status/copyset
branch
from
e6cd8d8
to
8c70d6e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What problem does this PR solve?
Issue Number: #xxx
Problem Summary:
What is changed and how it works?
What's Changed:
How it Works:
Side effects(Breaking backward compatibility? Performance regression?):
Check List